Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Promptflow] Support image in SingleNodeRun #811

Merged
merged 19 commits into from
Oct 23, 2023
Merged

[Promptflow] Support image in SingleNodeRun #811

merged 19 commits into from
Oct 23, 2023

Conversation

Hhhilulu
Copy link
Contributor

@Hhhilulu Hhhilulu commented Oct 18, 2023 •
edited
Loading

Description

Support image in SingleNodeRun.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Hhhilulu Hhhilulu requested a review from a team as a code owner October 18, 2023 08:30
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:30 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:30 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:30 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:30 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor Unit Test Result devs/luluzuo-internal-test

    2 files      2 suites   1m 52s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit b8b0f39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK PFS E2E Test Result devs/luluzuo-internal-test

8 tests   8 ✔️  29s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b8b0f39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Global Config Test Result devs/luluzuo-internal-test

2 tests   2 ✔️  1m 2s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b8b0f39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor E2E Test Result devs/luluzuo-internal-test

    2 files      2 suites   6m 54s ⏱️
107 tests 105 ✔️ 2 💤 0 ❌
214 runs  208 ✔️ 6 💤 0 ❌

Results for commit b8b0f39.

♻️ This comment has been updated with latest results.

@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:49 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:49 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:49 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 08:49 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Test Result devs/luluzuo-internal-test

    2 files      2 suites   32m 21s ⏱️
306 tests 293 ✔️ 13 💤 0 ❌
612 runs  586 ✔️ 26 💤 0 ❌

Results for commit 43f26aa.

♻️ This comment has been updated with latest results.

@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 14:20 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 14:20 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 14:20 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 14:20 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 14:20 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 16:49 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 16:49 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu changed the title Add Path type serialize [Promptflow] Support image in SingleNodeRun Oct 18, 2023
@Hhhilulu Hhhilulu temporarily deployed to internal October 18, 2023 17:27 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:37 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:37 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:37 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:37 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:37 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:39 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:39 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:39 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:39 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 04:39 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:09 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:09 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:09 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:09 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:09 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 06:54 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 07:40 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 07:40 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 07:40 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 07:40 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 07:40 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu merged commit 56ab01a into main Oct 23, 2023
27 of 29 checks passed
@Hhhilulu Hhhilulu deleted the devs/luluzuo-internal-test branch October 23, 2023 07:54
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaiyan huaiyan huaiyan left review comments

@guming-learning guming-learning guming-learning left review comments

@lumoslnt lumoslnt lumoslnt approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hhhilulu @thy09 @guming-learning @huaiyan @lumoslnt